-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add StepFunctionsCallbackPolicy policy template #3545
feat: add StepFunctionsCallbackPolicy policy template #3545
Conversation
Hello @kshyun28 , For new policy template PR, it has to go through security review which will take some time. We won't be able to merge the PR now. |
Hello @xazhao, I understand. If there's anything else required from me (or if the team thinks this is not a valid use case), please let me know. Thank you for reviewing! |
Hi there, just an update on this pull request. We've created the security review internally. It's pending a couple of tasks at the moment. Once the tasks are complete, we will bring it up the security engineer for a final round of review. |
Hi @kshyun28, sorry for the long wait! I've some good news to share with you. We've finally gotten security engineer's sign off and I will be merging this PR soon. |
Hello @GavinZZ, I appreciate all the hard work you and the AWS-SAM team did in order to add this feature. It's my pleasure making a small contribution to a tool I've used for serverless applications. |
Issue #, if available
#2193
Description of changes
Adds a new policy template
StepFunctionsCallbackPolicy
with the necessary permissions for implementing callback patterns.Description of how you validated changes
I validated the changes by updating the
translator
tests and runningmake test
onPython 3.8.16
.Total test coverage is at
95.73%
.Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam init
through aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.